Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another broadcast inconsistency with Base #199

Closed
bshall opened this issue May 29, 2017 · 2 comments · Fixed by #274
Closed

Another broadcast inconsistency with Base #199

bshall opened this issue May 29, 2017 · 2 comments · Fixed by #274

Comments

@bshall
Copy link
Contributor

bshall commented May 29, 2017

In Base you get

broadcast(+, [1], []) == [] # true
broadcast(+, [], [1]) == [] # true

but in StaticArrays you get

broadcast(+, SVector(1), SVector()) === SVector() # true
broadcast(+, SVector(), SVector(1)) === SVector() # DimesionMismatch error
@bshall bshall mentioned this issue May 29, 2017
Merged
@wsshin wsshin mentioned this issue Jul 8, 2017
Closed
@wsshin wsshin mentioned this issue Aug 8, 2017
Merged
c42f added a commit that referenced this issue Aug 11, 2017
@c42f
Merge pull request #274 from wsshin/broadcast
9779dd5 
Fix several broadcast issues (fixes #197, #199, #200, #242)
@wsshin
Copy link
Contributor

wsshin commented Aug 14, 2017

@bshall, this has been fixed by #274. Could you close this issue?

@c42f
Copy link
Member

c42f commented Aug 14, 2017

Sorry, I forgot to close this off. Github should have been auto-closed this, but perhaps it needs something like fixes #197, fixes #199 ...? Anyway, closing now.

@c42f c42f closed this as completed Aug 14, 2017
oschulz pushed a commit to oschulz/StaticArrays.jl that referenced this issue Apr 4, 2023
@johnnychen94 @piever
add a note about reinterpret's memory layout (JuliaArrays#199)
8958925 
* add a note about `reinterpret`'s memory layout

* rephrase the words

* apply suggestions

* move to advanced section

* add example for dims keyword

* one more note on `dims=ndims(v)`

* explain the memory order and the view perspective

* Minor wording change

Co-authored-by: Pietro Vertechi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix several broadcast issues (fixes #197, #199, #200, #242) wsshin/StaticArrays.jl
3 participants
@c42f @wsshin @bshall