Skip to content

Commit

Permalink
Fully qualify method extensions for Tuple constructor (#1293)
Browse files Browse the repository at this point in the history
  • Loading branch information
fredrikekre authored Feb 11, 2025
1 parent 89d8653 commit df49024
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "StaticArrays"
uuid = "90137ffa-7385-5640-81b9-e52037218182"
version = "1.9.11"
version = "1.9.12"

[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Expand Down
2 changes: 1 addition & 1 deletion src/MArray.jl
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ end
return v
end

@inline Tuple(v::MArray) = getfield(v,:data)
@inline Base.Tuple(v::MArray) = getfield(v,:data)

Base.dataids(ma::MArray) = (UInt(pointer(ma)),)

Expand Down
2 changes: 1 addition & 1 deletion src/SArray.jl
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ sacollect
getfield(v,:data)[i]
end

@inline Tuple(v::SArray) = getfield(v,:data)
@inline Base.Tuple(v::SArray) = getfield(v,:data)

Base.dataids(::SArray) = ()

Expand Down
2 changes: 1 addition & 1 deletion src/convert.jl
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ AbstractArray{T}(sa::StaticArray{S,U}) where {S,T,U} = similar_type(typeof(sa),T
AbstractArray{T,N}(sa::StaticArray{S,U,N}) where {S,T,U,N} = similar_type(typeof(sa),T,Size(sa))(sa)

# Constructing a Tuple from a StaticArray
@inline Tuple(a::StaticArray) = unroll_tuple(a, Length(a))
@inline Base.Tuple(a::StaticArray) = unroll_tuple(a, Length(a))

@noinline function dimension_mismatch_fail(::Type{SA}, a::AbstractArray) where {SA <: StaticArray}
throw(DimensionMismatch("expected input array of length $(length(SA)), got length $(length(a))"))
Expand Down

2 comments on commit df49024

@fredrikekre
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/124802

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.9.12 -m "<description of version>" df4902483177e4948911e7bdc5a50db82c8b4e6f
git push origin v1.9.12

Please sign in to comment.