Skip to content

Commit

Permalink
Force convert diagonal to real in eigen(::Hermitian) (#1280)
Browse files Browse the repository at this point in the history 
This matches the behavior for normal arrays
  • Loading branch information
@antoine-levitt
antoine-levitt authored Oct 21, 2024
1 parent b2f2fb0 commit b62e257
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/eigen.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ end
end
Sreal = real(S)

@inbounds a11 = convert(Sreal, A.data[1])
@inbounds a22 = convert(Sreal, A.data[5])
@inbounds a33 = convert(Sreal, A.data[9])
@inbounds a11 = convert(Sreal, real(A.data[1]))
@inbounds a22 = convert(Sreal, real(A.data[5]))
@inbounds a33 = convert(Sreal, real(A.data[9]))
if A.uplo == 'U'
@inbounds a12 = convert(S, A.data[4])
@inbounds a13 = convert(S, A.data[7])
Expand Down

2 comments on commit b62e257

@mateuszbaran
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/117804

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.9.8 -m "<description of version>" b62e2579f77983f48f7bc52e96d5d31d5d8e42b2
git push origin v1.9.8

Please sign in to comment.