Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is breaking and might be a good excuse to go to 1.0. Fixes the observation in #65 (comment) even for other array types that offset their axes (see this test).
The motivation is discussed in more detail in https://discourse.julialang.org/t/why-is-there-a-performance-hit-on-broadcasting-with-offsetarrays/32194. There's something pretty satisfying, though, about offsetting the axes by a "lazy" mechanism
OffsetArrays.jl/src/OffsetArrays.jl
Lines 18 to 21 in f383ae0
OffsetArrays.jl/src/OffsetArrays.jl
Lines 41 to 42 in f383ae0
because it makes it more possible to preserve any custom behavior of the parent array's axes.
CC @mbauman