Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #82: Reshape with Colon doesn't work, can segfault #84

Merged
merged 4 commits into from Nov 19, 2019
Merged

Fix issue #82: Reshape with Colon doesn't work, can segfault #84

merged 4 commits into from Nov 19, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2019

Fix issue #82.

@ghost ghost mentioned this pull request Nov 17, 2019
Closed
@timholy
Copy link
Member

timholy commented Nov 19, 2019

Thanks @mikan2087. Can I ask for a test? Using the MWE from JuliaLang/julia#33614 would seem sufficient.

@ghost
Copy link
Author

ghost commented Nov 19, 2019

@timholy Thank you for reviewing. I added some test cases.

@timholy timholy merged commit 0a68fac into JuliaArrays:master Nov 19, 2019
@timholy
Copy link
Member

timholy commented Nov 19, 2019

Thanks!

@ghost ghost deleted the wb branch November 19, 2019 13:56
@timholy timholy mentioned this pull request Nov 19, 2019
Closed
@ghost ghost mentioned this pull request Nov 21, 2019
Merged
@johnnychen94 johnnychen94 mentioned this pull request Sep 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@timholy