Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary reshape methods #367

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 18, 2024

Tests appear to pass without these as well, as these cases are handled correctly by the fallback methods.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (4ffdc70) to head (6a6b8ea).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
- Coverage   95.56%   95.52%   -0.04%     
==========================================
  Files           6        6              
  Lines         451      447       -4     
==========================================
- Hits          431      427       -4     
  Misses         20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit b704533 into master Dec 18, 2024
17 checks passed
@jishnub jishnub deleted the jishnub/reshape_methods_remove branch December 18, 2024 10:03
jishnub added a commit that referenced this pull request Dec 18, 2024
This should catch some missing cases in #367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant