Infinite IdOffsetRanges
#323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #323 +/- ##
==========================================
+ Coverage 96.45% 97.81% +1.35%
==========================================
Files 5 5
Lines 451 457 +6
==========================================
+ Hits 435 447 +12
+ Misses 16 10 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly forwards
Base.IteratorSize(::IdOffsetRange)to the parent, which allows us to potentially support infinite ranges as well. Infinite ranges are a bit of a sticky area, because currently inInifniteArrays, the last element of such a range is infinite, which usually has a different type from theeltypeof the range. Nonetheless, it might be possible to support some operations.I've also removed the
test/Project.toml, as it's not clear if this was much of a help