setindex! for mappedarray(f, finv, A, B, C...) (and deprecate f_finv tuple) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
- Coverage 100% 93.93% -6.07%
==========================================
Files 1 1
Lines 35 66 +31
==========================================
+ Hits 35 62 +27
- Misses 0 4 +4
Continue to review full report at Codecov.
|
This is motivated by preserving inferrability when passing types for either f or finv.
timholy
force-pushed
the
teh/multimapped
branch
2 times, most recently
from
05fb990
to
b04ec1e
Compare
|
There used to be a version of the |
|
I rebased and got something working in 0.6. If there's any interest it's available at https://github.com/Cody-G/MappedArrays.jl/tree/multimap_06 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rounds out the functionality for multi-mapping supporting
m[i] = vform = mappedarray(f, finv, A, B, C...).This also switches the writable interface from
mappedarray((f, finv), A, ...)tomappedarray(f, finv, A, ...). This seems necessary in order to ensure inferrability ifforfinvis a type. The only downside I see is that since any object can be made callable, this really commits at the API level to insisting thatA::AbstractArrayin order to be able to reliably resolve intent.