Fix incorrectly typed method for _vec_mul_arguments
#350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this method is implicitly assuming that the argument is a
::Tuple{Any}
but it will actually accept any argument, i.e. the method is_vec_mul_arguments(::Any, ::Any)
when it should be_vec_mul_arguments(::Any, ::Tuple{Any})
. For example, on master,I don't have the best test since the bug I encountered with this is buried in some other code (@dlfivefifty it came up when using
CircleCoordinate
which failed to match the correct method on Line 252 sinceCircleCoordinate
wasn't a number and so it went to this most generic method).Hopefully nothing downstream is relying on this behaviour somehow