Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional utilities for conversion to a DataFrame and for plotting with Gadfly #5

Merged
merged 2 commits into from
Feb 20, 2015

Conversation

tshort
Copy link
Collaborator

@tshort tshort commented Feb 20, 2015

This adds a dependency on Requires.jl. It's a small package that has worked well for me. The main advantage of this code is that it gives us a quick way to plot AxisArrays using Gadfly.

Note that this also requires the development version of DataFrames (I added a feature needed for this).

Note that this causes a ton of warnings when DataFrames and Gadfly are loaded. Most are due to other packages, but some are ambiguity warnings between DataArrays and AxisArrays. DataArrays will probably undergo a lot of change as they convert to some sort of Nullables representation, so I wouldn't worry about these for now. Ambiguity warnings are a PITA. Hopefully, Jeff's type work will fix all that.

with Gadfly.

Note that this adds a dependency to the Requires package.
@mbauman
Copy link
Member

mbauman commented Feb 20, 2015

Yes, now the real fun can begin! Good call on @require -- that seems to be the way to go here. I don't have computer access for the next few days, so you can take charge on the merge button.

I think we can have separate test REQUIRES file, so that'd be something to look into eventually (but isn't really critical for now).

tshort added a commit that referenced this pull request Feb 20, 2015
Add optional utilities for conversion to a DataFrame and for plotting with Gadfly
@tshort tshort merged commit 0c8b1b4 into master Feb 20, 2015
@mbauman mbauman mentioned this pull request Feb 24, 2015
14 tasks
@timholy
Copy link
Member

timholy commented Jul 27, 2016

Requires is a brilliant package, but it does some seriously-scary surgery, the tagged version is broken for julia-0.5, and on julia-0.5 generates the following unavoidable warning:

julia> using AxisArrays
WARNING: Method definition require(Symbol) in module Base at loading.jl:317 overwritten in module AxisArrays at /home/tim/.julia/v0.5/Requires/src/require.jl:12.

I'd like to recommend that we follow @tkelman's advice. Can this functionality be moved to a separate package?

@mbauman
Copy link
Member

mbauman commented Jul 27, 2016

Yup, I fully support that.

@timholy
Copy link
Member

timholy commented Jul 28, 2016

@tshort, are you OK with that? If so, do you want to host the package? Or put it at JuliaStats? I don't have commit access there, so I couldn't host it. If needed I'll start a package and request that it be transferred to a suitable home.

@tshort
Copy link
Collaborator Author

tshort commented Jul 28, 2016

I'd prefer just deleting/disabling the code and waiting until we get the extern keyword (JuliaLang/julia#15705).

@timholy
Copy link
Member

timholy commented Jul 28, 2016

I agree, the world is waiting eagerly for extern.

OK, I can do that. Thanks to git it's easy to get back. Thanks for your flexibility!

@timholy
Copy link
Member

timholy commented Jul 29, 2016

For the record, commit 08f266d has utils.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants