Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add necessary Documenter.jl files #29

Merged
merged 7 commits into from
Jun 27, 2016
Merged

Add necessary Documenter.jl files #29

merged 7 commits into from
Jun 27, 2016

Conversation

GordStephen
Copy link

Adds in the files necessary for implementing Documenter.jl. @mbauman will still need to do two steps (#1, #2) before it's up and running.

For now I just set the doc site homepage to have the same content as the README and created a second auto-generated reference page to display the package's docstrings - this can no doubt be improved on moving forward.

@mbauman
Copy link
Member

mbauman commented Jun 27, 2016

Sorry I'm slow on this! Is it possible for me to give you the necessary permissions here?

@GordStephen
Copy link
Author

No rush on my end - the blocking step would be adding a deploy key (for Travis) to the repository, which can only be done by the repository owner AFAIK.

- julia -e 'cd(Pkg.dir("AxisArrays")); Pkg.add("Coverage"); using Coverage; Coveralls.submit(Coveralls.process_folder())'
- julia -e 'cd(Pkg.dir("AxisArrays")); Pkg.add("Coverage"); using Coverage; Coveralls.submit(Coveralls.process_folder())'
- julia -e 'Pkg.add("Documenter")'
- julia -e 'cd(Pkg.dir("AxisArrays")); include(joinpath("doc", "make.jl"))'
Copy link
Author

@GordStephen GordStephen Jun 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"doc" -> "docs" will need to be changed here too (https://travis-ci.org/mbauman/AxisArrays.jl/jobs/140622570#L464)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks! I think I got all the keys set up now, too, so we'll see if it works after this push. If you'd prefer, I can now move the folder back, but the Documenter setup tasks seemed to assume this layout… so this was the path of least resistance.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing it makes sense, best to stick with the Documenter defaults unless there's a reason to deviate I think.

@mbauman
Copy link
Member

mbauman commented Jun 27, 2016

Hm, I don't think that last step is necessary (it errors and other packages don't seem to do it). I think this just needs to be on master for it to work now — Documenter.jl simply reports "skipping deployment".

Ready to merge?

@GordStephen
Copy link
Author

For sure! 👍

@GordStephen GordStephen merged commit 127bf45 into master Jun 27, 2016
@mbauman mbauman deleted the documenter branch June 27, 2016 20:46
@GordStephen
Copy link
Author

Lots of room for improvement, but it's a start: http://mbauman.github.io/AxisArrays.jl/latest/

@mbauman mbauman mentioned this pull request Jul 23, 2016
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants