Some quiet type cleanup #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbauman
reviewed
Sep 21, 2017
| @@ -143,10 +143,10 @@ A[ClosedInterval(0.,.3), [:a, :c]] # select an interval and two columns | |||
| ``` | |||
|
|
|||
| """ | |||
| struct AxisArray{T,N,D,Ax} <: AbstractArray{T,N} | |||
| struct AxisArray{T,N,D<:AbstractArray{T,N},Ax<:NTuple{N,Axis}} <: AbstractArray{T,N} | |||
There was a problem hiding this comment.
Long time ago there were some very subtle and surprising dispatch issues in doing this. Looks like at least the minimal case I reported still exists:
julia> struct Foo{A<:Real}; end
f(x::Foo{A}) where A = 1 # Method sorting doesn't take into account `A <: Real`
f(x::Foo, y...) = 2 # Implicitly assumes `A <: Real`
f (generic function with 2 methods)
julia> f(Foo{Int}())
2
Not sure if any other methods still depend on that behavior.
There was a problem hiding this comment.
Ah, the ambiguity no longer occurs but that still happens.
Do you know if there is a Julia issue for this behaviour?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was staring at the AxisArrays code and this was bothering me so I changed it 🙃
DandAxare enforced in the type itself. Only one change was required to remove ambiguities.NTuple{N, _}is now consistently used instead ofTuple{Vararg{_, N}}.Tuple{Vararg{_}}remains to indicate actual possible variation.