RFC: consider @v macro for value indexing #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #84, #117.
I don't intend/expect to merge this, mainly I put it up here as food for thought. I support using value indexing by default, but whatever the implementation I think there ought to be a first-class way to use normal indexing if desired (I would not be okay with having to do
A.data[1,2]
to use normal indices, for example). It would also be nice to provide some mechanism to adjust the tolerances when doing floating-point comparisons, though I feel less strongly about that since the default tolerances usually work fine.This approach does not switch to value indexing by default, but provides (at least in my view) a convenient alternative that satisfies my concerns:
It has some downsides:
@v
is pretty terse for an exported symbol, but@value
would be super annoying to type