revert #449 #451
Merged
revert #449 #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #451 +/- ##
==========================================
- Coverage 70.28% 70.17% -0.11%
==========================================
Files 11 11
Lines 562 560 -2
==========================================
- Hits 395 393 -2
Misses 167 167 ☔ View full report in Codecov by Sentry. |
| @@ -21,10 +21,6 @@ ArrayInterface.can_setindex(::Type{<:StaticArray}) = false | |||
| ArrayInterface.can_setindex(::Type{<:MArray}) = true | |||
| ArrayInterface.buffer(A::Union{SArray, MArray}) = getfield(A, :data) | |||
|
|
|||
| function ArrayInterface.lu_instance(A::SMatrix{N,N}) where {N} | |||
There was a problem hiding this comment.
because StaticArrays.LU (which is not the same as LinearAlgebra.LU) is defined in StaticArrays not StaticArraysCore
There was a problem hiding this comment.
Didn't we need this for performance? What about having a StaticArraysExt for just this one?
There was a problem hiding this comment.
I tried that locally and it causes invalidations during precompile which is illegal. I'll just hack my way around it...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the SArray types are created in StaticArraysCore, unfortunately we need the extension to be on the library or else generated functions in 3rd party packages can miss the added methods. Furthermore, this breaks the ability to optimize
lusinceStaticArraysCoredoesn't defineStaticArrays.LUso this just is really annoying. I really think we should delete StaticArraysCore and just make it an alias for StaticArrays now that extension packages exist.