Create ArrayInterfaceStaticArraysCore #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that there's StaticArraysCore, to have minimal dependencies I created ArrayInterfaceStaticArraysCore which only requires ArrayInterfaceCore and StaticArraysCore and implements all of the possible functions given those constraints (i.e. no static-ness), which covers all of the functions which are actually used by SciML downstream packages. Thus this will have a massive effect on downstream load times. As a result, a patch bump to ArrayInterfaceStaticArrays is done which just includes the core version so it's non-breaking.
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
=======================================
Coverage 91.10% 91.10%
=======================================
Files 9 9
Lines 1462 1462
=======================================
Hits 1332 1332
Misses 130 130 Continue to review full report at Codecov.
|
|
Heavily tested locally. |
ChrisRackauckas
added a commit
to SciML/RecursiveArrayTools.jl
that referenced
this pull request
Jun 25, 2022
Requires JuliaArrays/ArrayInterface.jl#325 ```julia @time_imports using SciMLBase 10.4 ms ┌ MacroTools 19.0 ms ┌ ZygoteRules 3.8 ms ┌ Compat 1.5 ms ┌ Adapt 3.7 ms ┌ ArrayInterfaceCore 2.0 ms ┌ StaticArraysCore 9.7 ms ┌ ArrayInterfaceStaticArraysCore 123.1 ms ┌ FillArrays 5.0 ms ┌ DocStringExtensions 18.2 ms ┌ RecipesBase 51.3 ms ┌ ChainRulesCore 4.0 ms ┌ GPUArraysCore 292.7 ms RecursiveArrayTools ``` Compare that to #213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that there's StaticArraysCore, to have minimal dependencies I created ArrayInterfaceStaticArraysCore which only requires ArrayInterfaceCore and StaticArraysCore and implements all of the possible functions given those constraints (i.e. no static-ness), which covers all of the functions which are actually used by SciML downstream packages. Thus this will have a massive effect on downstream load times. As a result, a patch bump to ArrayInterfaceStaticArrays is done which just includes the core version so it's non-breaking.