Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster gaussjacobi and gausslobatto, and refactoring #85

Merged
merged 8 commits into from
Jan 4, 2021

Conversation

hyrodium
Copy link
Collaborator

Benchmark

Current master branch↓
image

This branch↓
image

About twice faster and less memory usage:tada:

Type unstability

There were type unstabilities in some functions.
For example:
image

But, in this branch, this problem is solved!
image

The trap of Adjoint

The type unstability was because of Adjoint.
Here's a small example:
image

Related issue in Julia↓
JuliaLang/julia#32289

Refactored things

  • Update error-handling
  • More comments

@hyrodium hyrodium changed the title Faster gaussjacobi and gausslobatto and refactoring Faster gaussjacobi and gausslobatto, and refactoring Dec 31, 2020
@codecov
Copy link

codecov bot commented Dec 31, 2020

Codecov Report

Merging #85 (1a975de) into master (ba2da14) will increase coverage by 1.36%.
The diff coverage is 99.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   94.71%   96.08%   +1.36%     
==========================================
  Files           9        9              
  Lines        1116     1123       +7     
==========================================
+ Hits         1057     1079      +22     
+ Misses         59       44      -15     
Impacted Files Coverage Δ
src/FastGaussQuadrature.jl 83.33% <ø> (ø)
src/gaussjacobi.jl 97.10% <99.02%> (+0.39%) ⬆️
src/besselroots.jl 92.68% <100.00%> (+2.68%) ⬆️
src/gausschebyshev.jl 100.00% <100.00%> (+10.00%) ⬆️
src/gausshermite.jl 100.00% <100.00%> (+3.19%) ⬆️
src/gausslaguerre.jl 92.04% <100.00%> (+0.85%) ⬆️
src/gausslegendre.jl 98.07% <100.00%> (+0.98%) ⬆️
src/gausslobatto.jl 100.00% <100.00%> (+6.66%) ⬆️
src/gaussradau.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba2da14...1a975de. Read the comment docs.

@dlfivefifty dlfivefifty merged commit c52b3bc into JuliaApproximation:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants