Add normalize option to gausshermite
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #122 +/- ##
=======================================
Coverage 96.65% 96.65%
=======================================
Files 9 9
Lines 1224 1224
=======================================
Hits 1183 1183
Misses 41 41
☔ View full report in Codecov by Sentry. |
hyrodium
reviewed
Sep 14, 2023
sure, thanks |
hyrodium
reviewed
Sep 14, 2023
src/gausshermite.jl
Outdated
| @@ -1,12 +1,18 @@ | |||
| @doc raw""" | |||
| gausshermite(n::Integer) -> x, w # nodes, weights | |||
| gausshermite(n::Integer; probabilist = false) -> x, w # nodes, weights | |||
There was a problem hiding this comment.
Suggested change
| gausshermite(n::Integer; probabilist = false) -> x, w # nodes, weights | |
| gausshermite(n::Integer; normalize = false) -> x, w # nodes, weights |
Maybe, some other name of the keyword argument would be better?
There was a problem hiding this comment.
I've made your suggested changes and added tests.
hyrodium
requested changes
Sep 15, 2023
done |
hyrodium
changed the title
normalize option to gausshermite
hyrodium
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an option that allows users to specify that they want the probabilist version of the Gauss Hermite weights. The documentation has been updated, also.