Repository navigation
ci(dependabot): block auto-merge when a package.json changes without its lockfile - #135
Merged
Merged
Conversation
…its lockfile Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependabot pull requests #119 and #120 updated
frontend-sites/package.jsonandfrontend-sites/package-lock.jsonwithout the rootpackage-lock.json. Rootnpm cithen failed because the workspace manifest and the hoisted lock were out of sync.The auto-merge job now reads
gh pr diff --name-onlyafter Dependabot metadata and beforegh pr merge --auto. A patch or minor pull request that changes anypackage.jsonis auto-merged only when the rootpackage-lock.jsonis in that diff. A workspace-local lockfile does not satisfy the check. When the root lock is missing, the job comments on the pull request and leaves auto-merge off. Pull requests with nopackage.jsonchange (NuGetcsprojbumps) are unchanged.frontend-sitesminor and patch updates fornext,react,react-dom, and@types/*now share one Dependabot group so those manifests move together. That group still does not update the root lock; the guard keeps auto-merge off until it does.Test plan
frontend-sites/package.json+ local lock, no root lock) blocks auto-merge.package.jsonplus rootpackage-lock.json) allows auto-merge.