Upgrade rouge to 2.0.7 #10
Conversation
test/rouge_filter_test.rb
Outdated
| @@ -95,6 +95,6 @@ def test_replacing_br | |||
|
|
|||
| doc = filter.call | |||
| assert_equal "<pre class=\"highlight highlight-ruby\"><code>"\ | |||
| "<span class=\"n\">hello</span>\n<span class=\"n\">world</span></code></pre>\n", doc.to_html | |||
| "<span class=\"n\">hello</span>\n<span class=\"n\">world</span></code></pre>", doc.to_html | |||
There was a problem hiding this comment.
Line is too long. [107/80]
Good for now 👍 Oh wow, thanks so much for the upadtes, looks like CI-san is not happy 😂 Would you take a look into that 🙏 |
Sure. I'll investigate that 🙋♀️ |
* activesupport-5.0.0 or later don't support ruby < 2.1.0. * Latest activesupport (5.0.2) doesn't support ruby < 2.2.2. * nokogiri-1.7.0 or later don't support ruby < 2.1.0.
|
There are some gems which don't support certain old runtime. I've made setting upper limit of these versions only if the runtime is not supported by latest gems (43096f3).
|
|
Thanks so much for the hard work!!!!! 👍 💯 Do you want to be a committer of this project? 👩🏻💻 |
|
Shipped in v1.0.5!!! 🐑 |
|
Thanks!!!!!
Yes I do 😸 It's an honor. |
Hello. Thank you for the nice integration gem!
Since there are new lexers and fixes which were added after rouge-0.8, I'd love to use html-pipeline-rouge_filter with latest rouge (2.0.7).
The API of rouge has been changed since 2.0.0. Although I'm not sure how to deal with these new formatters via this filter, it seems possible to upgrade rouge without making API changes by using
Rouge::Formatters::HTMLLegacyfor now. This Pull Request does it.What do you think? Let me know your opinion.