Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Hotfix: Unresponsive Proxy API #4842

Merged
merged 4 commits into from
Apr 25, 2024
Merged

🔥 Hotfix: Unresponsive Proxy API #4842

merged 4 commits into from
Apr 25, 2024

Conversation

thesan
Copy link
Collaborator

@thesan thesan commented Apr 24, 2024

Fixes #4839 and #4837 (this one was due to unoptimised re-rendering in this proposal but I'm not sure why it got worse after upgrading the dependencies).

thesan added 4 commits April 22, 2024 12:11
e.g all `api.derive` were sharing the same cold observable.
Which resulted in all other payloads being deserialize on every emitted message (from other `api.derive` queries).
Same thing for `api.query` and `api.rpc`.
This reverts commit 7337a7d.
@thesan thesan added the hot-fix label Apr 24, 2024
@thesan thesan requested a review from kdembler April 24, 2024 19:21
Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Apr 24, 2024 7:33pm
pioneer-2 ✅ Ready (Inspect) Visit Preview Apr 24, 2024 7:33pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Apr 24, 2024 7:33pm

@thesan thesan changed the title 🔧 Fix Proxy API becoming unresponsive 🔥 Hotfix: Proxy API becoming unresponsive Apr 24, 2024
@thesan thesan changed the title 🔥 Hotfix: Proxy API becoming unresponsive 🔥 Hotfix: Unresponsive Proxy API Apr 24, 2024
@thesan
Copy link
Collaborator Author

thesan commented Apr 24, 2024

@kdembler to demonstrate the issue I enabled the "ProxyAPI" on the pioneer-2 Vercel deployments:

The problem happens once you connect 2 or more accounts to Pioneer because it causes several queries of one type to share the same cold observable. It was probably just making the app a bit slower before Luxor, but now due to some changes in the balance object it caused an infinite loop.

I'm still not sure of why it doesn't happens on https://pioneer.joyutils.org. My guess is that the "ProxyAPI" is disabled there for some reason.

@kdembler kdembler merged commit 0e563b4 into main Apr 25, 2024
7 checks passed
@kdembler kdembler deleted the hotfix/luxor-app-freeze branch April 25, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants