-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add notifications settings tab #4563
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kdembler
force-pushed
the
backend-settings
branch
from
October 6, 2023 09:48
5a20ea8
to
9e634a5
Compare
thesan
added
scope:notifications
Notifications subsystem
community-dev
issue suitable for community-dev pipeline
labels
Oct 6, 2023
kdembler
force-pushed
the
backend-settings
branch
from
October 11, 2023 12:55
9e634a5
to
436b8a7
Compare
thesan
requested changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great PR 🤩
Just 2 small changes for the error and loading state
packages/ui/src/app/pages/Settings/SettingsNotificationsTab.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/app/pages/Settings/SettingsNotificationsTab.tsx
Outdated
Show resolved
Hide resolved
packages/ui/src/app/pages/Settings/SettingsNotificationsTab.tsx
Outdated
Show resolved
Hide resolved
thesan
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds notifications tab to settings
Resolves #4231