Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add notifications settings tab #4563

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Conversation

kdembler
Copy link
Collaborator

@kdembler kdembler commented Oct 5, 2023

⚠️ Based on #4551 and #4561, review those first ⚠️

Adds notifications tab to settings

Resolves #4231

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Oct 16, 2023 11:43am
pioneer-2 ✅ Ready (Inspect) Visit Preview Oct 16, 2023 11:43am
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Oct 16, 2023 11:43am

Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great PR 🤩

Just 2 small changes for the error and loading state

Copy link
Collaborator

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@thesan thesan merged commit a66bb24 into Joystream:backend Oct 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-dev issue suitable for community-dev pipeline scope:notifications Notifications subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants