test max white list (#2491) #4126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
traumschule
suggested changes
Jan 28, 2023
Comment on lines
27
to
30
| if (watch.length < 20) | ||
| setValue('triggerAndDiscussion.discussionWhitelist', [...discussionWhitelist, member], { | ||
| shouldValidate: true, | ||
| }) |
There was a problem hiding this comment.
For this existing validation has to be used for additional error:
limit max whitelist members to 20 and show validation error "Maximum whitelist size of 20 members is reached." Underneath the field in blue info panel style and disable selector for new additional members
traumschule
requested review from
gyroflaw and
oleksanderkorn
and removed request for
thesan and
dmtrjsg
traumschule
reviewed
Feb 3, 2023
| @@ -172,7 +172,8 @@ export const schemaFactory = (api?: ProxyApi) => { | |||
| isDiscussionClosed: Yup.boolean(), | |||
| discussionWhitelist: Yup.array().when('isDiscussionClosed', { | |||
| is: true, | |||
| then: Yup.array().required('Field is required'), | |||
| then: Yup.array().test(maxContext('The maximum block number is ${20}', 'maxTriggerBlock', false)) | |||
There was a problem hiding this comment.
It may be something like here - @WRadoslaw Please advise.
Suggested change
| then: Yup.array().test(maxContext('The maximum block number is ${20}', 'maxTriggerBlock', false)) | |
| then: Yup.array().test(maxContext('The whitelist is limited to ${max} members', (value, context) => { | |
| if (!value?.length) return true | |
| const validationContext = context.options.context as Conditions | |
| return (validationContext.maxWhitelistSize ?? BN_ZERO).gten(value.length) | |
| }), false)) |
oleksanderkorn
suggested changes
Feb 4, 2023
| @@ -24,8 +24,12 @@ export const TriggerAndDiscussionStep = () => { | |||
| ]) | |||
|
|
|||
| const addMemberToWhitelist = (member: Member) => { | |||
| setValue('triggerAndDiscussion.discussionWhitelist', [...discussionWhitelist, member], { shouldValidate: true }) | |||
| // if (watch.length < 20) | |||
There was a problem hiding this comment.
Can we remove commented code?
| @@ -3,13 +3,16 @@ import * as Yup from 'yup' | |||
|
|
|||
| import { Account } from '@/accounts/types' | |||
| import { QuestionValueProps } from '@/common/components/EditableInputList/EditableInputList' | |||
| import { BN_ZERO } from '@/common/constants' | |||
There was a problem hiding this comment.
Unused imports:
Suggested change
| import { BN_ZERO } from '@/common/constants' |
Comment on lines
14
to
15
| import { Conditions } from '../../../bounty/modals/AddBountyModal/helpers' | ||
|
|
There was a problem hiding this comment.
Unused imports:
Suggested change
| import { Conditions } from '../../../bounty/modals/AddBountyModal/helpers' |
| @@ -7,6 +7,7 @@ import { Arrow } from '@/common/components/icons' | |||
| import { ListItem } from '@/common/components/List' | |||
| import { RowGapBlock } from '@/common/components/page/PageContent' | |||
| import { ProgressBar } from '@/common/components/Progress' | |||
| import { Tooltip, TooltipDefault } from '@/common/components/Tooltip' | |||
There was a problem hiding this comment.
TooltipDefault import is not used, can we remove this one?
Suggested change
| import { Tooltip, TooltipDefault } from '@/common/components/Tooltip' | |
| import { Tooltip } from '@/common/components/Tooltip' |
oleksanderkorn
suggested changes
Feb 16, 2023
There was a problem hiding this comment.
@chrlschwb I do not see any changes fixing the original issue, I only see some code formatting. Is it expected?
chrlschwb
force-pushed
the
fix/2491-maxWhiteListSize
branch
from
255c533 to
57d03ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #2491