Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forum category position removal #838

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

ondratra
Copy link
Contributor

@ondratra ondratra commented Jun 30, 2020

Solves subtask of #766 - Drop the concept of ChildPositionInParentCategory which is used for Category.position_in_parent_category, just use an optional identifier to a parent.

To minimize merge conflict potential, this PR assumes #827 will be merged first.

@ondratra ondratra mentioned this pull request Jun 30, 2020
@ondratra ondratra marked this pull request as ready for review June 30, 2020 17:27
@bedeho bedeho changed the base branch from forum_2 to master July 1, 2020 13:40
@bedeho bedeho changed the base branch from master to forum_2 July 1, 2020 13:40
@bedeho bedeho self-requested a review July 1, 2020 13:41
Copy link
Member

@bedeho bedeho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@bedeho bedeho merged commit f8338dd into Joystream:forum_2 Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants