Skip to content

Conversation

@mnaamani
Copy link
Member

@mnaamani mnaamani commented May 19, 2020

  • Preparing final runtime versioning for Constantinople release.
  • Adjusting runtime parameters: Unbonding period for validators and modifying the reward curve as per Runtime changes for Rome #388
  • Update docker files to allow building joystream/node with Rust v1.43.0

@mnaamani mnaamani changed the title bump runtime spec version to 13 and node binary version to v2.2.0 Set runtime spec version to 13 and joystream-node binary version to v2.2.0 May 19, 2020
@mnaamani mnaamani requested a review from shamil-gadelshin May 19, 2020 08:40
@mnaamani mnaamani requested a review from bwhm May 19, 2020 08:40
@mnaamani mnaamani marked this pull request as ready for review May 19, 2020 16:28
ideal_stake: 0_300_000,
falloff: 0_050_000,
max_piece_count: 40,
max_piece_count: 100,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bwhm just wanted to bring your attention to this change of the max_piece_count. I increased it following change to max_inflation and ideal_stake because the unit test failure suggested so:

---- __srml_staking_reward_curve_test_module::reward_curve_precision stdout ----
thread '__srml_staking_reward_curve_test_module::reward_curve_precision' panicked at '
Generated reward curve approximation differ from real one:
	for i = 364050 and base = 1000000, f(i/base) * base = 138165,
	but approximation = 138856,
	err = 0005001 millionth,
	try increase the number of segment: 40 or the test_error: 5000.

Copy link
Contributor

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shamil-gadelshin shamil-gadelshin merged commit 662c0fe into Joystream:development May 20, 2020
@mnaamani mnaamani deleted the constantinople-release branch May 22, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants