Remove council blog pallet and proposals #3971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
L3pereira
changed the title
dobertRowneySr
suggested changes
Jun 28, 2022
Collaborator
dobertRowneySr
left a comment
dobertRowneySr
left a comment
There was a problem hiding this comment.
Looks good but there are some conflicts to solve
L3pereira
force-pushed
the
remove_council_blog_pallet_and_proposals_#3662
branch
from
3400ce5 to
3488660
Compare
dobertRowneySr
suggested changes
Jun 30, 2022
Collaborator
There was a problem hiding this comment.
- build node & runtime ✔️
- types and metadata ✔️
- cargo test ✔️
- there are some problem with benchmarks:
---- tests::council_discard_remaining_rewards_on_depose stdout ----
thread 'tests::council_discard_remaining_rewards_on_depose' panicked at 'attempt to subtract with overflow', runtime-modules/council/src/mock.rs:1496:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
---- tests::council_many_cycle_rewards stdout ----
thread 'tests::council_many_cycle_rewards' panicked at 'attempt to subtract with overflow', runtime-modules/council/src/mock.rs:1496:17
---- tests::council_rewards_are_paid stdout ----
thread 'tests::council_rewards_are_paid' panicked at 'attempt to subtract with overflow', runtime-modules/council/src/mock.rs:1496:17
---- tests::vote_stake_locks_after_new_election_starts stdout ----
thread 'tests::vote_stake_locks_after_new_election_starts' panicked at 'attempt to subtract with overflow', runtime-modules/council/src/mock.rs:1496:17
These should be fixed see mnaamani#13
L3pereira
force-pushed
the
remove_council_blog_pallet_and_proposals_#3662
branch
from
3488660 to
4de447d
Compare
remove_blog_proposals_#3662 remove_council_blog_pallet_and_proposals_#3662 remove_council_blog_typescript_pallet_and_proposals_#3662 remove_council_blog_typescript_pallet_and_proposals_#3662 requested changes + cargo fmt in types.rs requests + types + metadata chain metadata
L3pereira
force-pushed
the
remove_council_blog_pallet_and_proposals_#3662
branch
from
4de447d to
970b8a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove blog related proposals e9b6455
Remove pallet-blog e43711e
Remove blog related typescript f046818
┆Issue is synchronized with this Asana task by Unito