build script for network tests added, readme updated #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaamani
requested changes
May 8, 2020
Member
mnaamani
left a comment
mnaamani
left a comment
There was a problem hiding this comment.
Nice trick, just needs small fix to use the edited chainspec.json file, maybe also add the chainspec.json file to .gitignore ?
scripts/run-test-chain.sh
Outdated
| sed -i 's/"evictStorageProviderProposalGracePeriod":.*/"evictStorageProviderProposalGracePeriod": 0,/' chainspec.json | ||
| sed -i 's/"setStorageRoleParametersProposalGracePeriod":.*/"setStorageRoleParametersProposalGracePeriod": 0,/' chainspec.json | ||
| yes | cargo run --release -p joystream-node -- purge-chain --dev | ||
| cargo run --release -p joystream-node -- --dev |
Member
There was a problem hiding this comment.
Suggested change
| cargo run --release -p joystream-node -- --dev | |
| cargo run --release -p joystream-node -- --chain ./chainspec.json |
To use the custom chainspec file that was produced.
Contributor
Author
There was a problem hiding this comment.
Fixed, also removed build from the script
Member
|
Included in #399 |
Lezek123
pushed a commit
to Lezek123/substrate-runtime-joystream
that referenced
this pull request
May 21, 2020
Proposal forms: Extrinsics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.