-
Notifications
You must be signed in to change notification settings - Fork 115
Feature/rome constatinople migration test #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mnaamani
merged 12 commits into
Joystream:development
from
gleb-urvanov:feature/rome-constatinople-migration-test
May 15, 2020
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6fc4a5f
Rome Constantinople migration test implementation
gleb-urvanov b71e471
updated runtime from Rome to Constantinople
gleb-urvanov c38eae6
Rome to Constantinople migration test fix
gleb-urvanov 7ee50ee
new yarn command introduces to run migration test
gleb-urvanov b7a25ff
Merge branch 'development' into feature/rome-constatinople-migration-…
gleb-urvanov d2a0ce8
code cleaning, minor fixes
gleb-urvanov e449e46
Merge branch 'development' into feature/rome-constatinople-migration-…
gleb-urvanov 2c7252f
make batch balance transfer sequential
gleb-urvanov cd1bf82
proposal tests skipped
gleb-urvanov 3f25c78
rome constantinople test finished, new proposals moved to separate br…
gleb-urvanov c4a253f
path to runtime parameterized
gleb-urvanov b5b36a2
review feedback applied
gleb-urvanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,3 +22,6 @@ yarn* | |
|
|
||
| # Visual Studio Code | ||
| .vscode | ||
|
|
||
| # Compiled WASM code | ||
| *.wasm | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the first "@joystream/types": "../joystream-apps/packages/joy-types", is just a relative path to the latest constantinople @joystream/types package.
But I wanted to confirm my understanding, "@rome/types@npm:@joystream/types" is setting some sort of alias from
@rome/typesto@joystream/typespublished on npm ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to do something like:
This might be useful but what would be more helpful is to see if we can have two packages in the same workspace setup the same alias to two different versions of the same package name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot merge with package.json having such a relative path to a dependency.
How can we tackle this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, it's an alias.
Yes, after .8 will be published to nexus
We can either publish .8 types, or I can put a placeholder here for the relative path.