-
Notifications
You must be signed in to change notification settings - Fork 115
Giza olympia fix bundled video creation and nft issuance #3137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Giza olympia fix bundled video creation and nft issuance #3137
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/joystream/pioneer-testnet/DrgnfQDUqymLYmQCctq2MRypMk1t [Deployment for a6d433f canceled] |
a8043f2 to
0f174e1
Compare
I could locate the |
5884162 to
89376b3
Compare
89376b3 to
af45c7f
Compare
af45c7f to
fe745c8
Compare
|
|
||
| Self::deposit_event(RawEvent::VideoCategoryDeleted(actor, category_id)); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it a rebase artifact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not following. The BASE commit in olympia has this code. In this PR that I am opening I removed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. So, it's part of the PR. I was expecting only the NFT-related code.
fe745c8 to
195458d
Compare
cfd1513 to
a6d433f
Compare
shamil-gadelshin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes:
I also removed all the unused code like
PersonIdand the likes that was not removed this far, in order to have cleaner type aliasesUpdate 2022-02-02: rebased to currentolympia. This lead to a larger number of commitsRelevant comits start from : c86b9dd
Relevant code section are in the
contentmodule, in particular:NFTIssuanceParametertype introducedInitTransactionalStatustype introducedensure_valid_init_transactional_statusguard addedcreate_video&issue_nftextrinsic argument modified