Skip to content

Conversation

@shamil-gadelshin
Copy link
Contributor

@shamil-gadelshin shamil-gadelshin commented Jan 27, 2022

We need to expose allowed lock ID combinations to the frontend (#2825).

The are several approaches to implement this:

  • an option using node RPC with rich functionality has its downsides: a necessity to force all nodes to be updated in case of the RPC change - imposing an additional hardfork demand that we generally should avoid because of the Substrate's softfork capabilities. Consult with @mnaamani on the details.
  • I chose to expose the allowed lock combinations via the joystreamUtility pallet's constants. The constant name is AllowedLockCombinations. It returns the set of the allowed lock ID pairs.

Fixes:

@vercel
Copy link

vercel bot commented Jan 27, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/joystream/pioneer-testnet/F6HnNbxB7EFYhqwmRVV6c5XCGyDb
✅ Preview: Canceled

[Deployment for d7f0231 canceled]

@shamil-gadelshin shamil-gadelshin changed the title Olympia. Runtime expose allowed lock ID combinations. Olympia. Runtime. Expose allowed lock ID combinations. Jan 27, 2022
@shamil-gadelshin shamil-gadelshin self-assigned this Jan 27, 2022
@shamil-gadelshin shamil-gadelshin marked this pull request as ready for review January 27, 2022 15:26
@shamil-gadelshin
Copy link
Contributor Author

FYI @jodator

@jodator
Copy link
Contributor

jodator commented Jan 31, 2022

FYI @jodator

FYI @dmtrjsg – something for the Pioneer team to look into. Looks helpful :)

Copy link
Member

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs merge conflict fixes.

@shamil-gadelshin shamil-gadelshin merged commit fb4ffa9 into Joystream:olympia Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants