Skip to content

Conversation

@mnaamani
Copy link
Member

@mnaamani mnaamani commented Apr 15, 2020

Ensure build() is called for SpecVersion state storage value to be correctly initialized, otherwise the call to runtime_upgraded() was incorrectly being called at block 1.

Will also implement additional migration steps from: #224

@mnaamani mnaamani changed the title migration: fix setting initial spec value at genesis Runtime: Migration module - fix setting initial spec value at genesis Apr 15, 2020
@mnaamani mnaamani changed the title Runtime: Migration module - fix setting initial spec value at genesis Runtime: Migration module - migrations for constantinople Apr 15, 2020
@mnaamani mnaamani requested review from bedeho and shamil-gadelshin and removed request for bedeho April 27, 2020 08:00
Copy link
Contributor

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bedeho bedeho merged commit 82b6109 into Joystream:development May 15, 2020
@mnaamani mnaamani deleted the migration-constantinople branch May 21, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants