Skip to content

Add set_election_parameters() replacing individual calls #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shamil-gadelshin merged 4 commits into from
Mar 27, 2020
Merged

Add set_election_parameters() replacing individual calls #250

shamil-gadelshin merged 4 commits into from
Mar 27, 2020

Conversation

@mnaamani
Copy link
Member

@mnaamani mnaamani commented Mar 26, 2020

Implements #238
Names the function set_election_parameters instead of set_council_parameters.

@mnaamani mnaamani marked this pull request as ready for review March 26, 2020 13:56
@mnaamani mnaamani mentioned this pull request Mar 26, 2020
Closed
@mnaamani
Copy link
Member Author

mnaamani commented Mar 27, 2020

Will need to add struct ElectionParameters type to @joystream/types

shamil-gadelshin
shamil-gadelshin approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shamil-gadelshin shamil-gadelshin merged commit 3791800 into Joystream:development Mar 27, 2020
@mnaamani mnaamani deleted the council-set-election-parameters branch May 21, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shamil-gadelshin shamil-gadelshin shamil-gadelshin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mnaamani @shamil-gadelshin