Runtime warning cleanup #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrated to the WasmBuilder.
mnaamani
reviewed
Mar 12, 2020
| } | ||
|
|
||
| impl UpdateCuratorRewardAccountFixture { | ||
| #[allow(dead_code)] // delete if the method is unnecessary |
Member
There was a problem hiding this comment.
what is different about these methods that we are allowing dead_code rather than removing like in other fixtures?
Member
|
Nice this Fixes #180 |
mnaamani
reviewed
Mar 12, 2020
| unstaking_application_count, | ||
| deactivated_application_count, | ||
| } => { | ||
| hiring::OpeningStage::Active { stage, .. } => { |
Member
There was a problem hiding this comment.
nice, I learned the proper way now to ignore fields in match statements 👍
mnaamani
pushed a commit
to mnaamani/joystream
that referenced
this pull request
Apr 16, 2020
Update to Rome testnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings were cleaned:
srml_staking_reward_curve::build!is part of the substrate and is likely to be updated on next substrate upgrade.