Proposals update. Parameters migration from the Storage to the Trait.#1680
Merged
mnaamani merged 27 commits intoJoystream:proposals_updatefrom Nov 18, 2020
Merged
Conversation
# Conflicts: # runtime/src/proposals_configuration/mod.rs
mnaamani
approved these changes
Nov 16, 2020
Member
|
Only issue here is that the CI checks specifically for network integration tests are from an old branch. |
# Conflicts: # Cargo.lock # runtime-modules/proposals/discussion/Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We created a separate runtime module(file) In order to be able to pass the proposal parameter constants during the compilation time. The primary goal for the conditional compilation is integration tests. All parameters for the proposal could be set via
ALL_PROPOSALS_PARAMETERS_JSONenvironment variable. The value of the variable should be a valid JSON file (a sample file is included in the PR). The PR contains a migration of the single proposal parameter set for demo purposes.Comments
lite-jsoncrate as "no_std" option for parsing JSON recommended for Substrate.serde_jsonis not 'no_std' ready.serder_json_corelibrary is not working.ignore).The previous draft PR could be found here.