runtime: Update the chain constants. #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - SlashDeferDuration changed to the BONDING_DURATION - 1 - Staking history_depth was increased to 336
bwhm
reviewed
Sep 10, 2020
| .collect(), | ||
| invulnerables: initial_authorities.iter().map(|x| x.0.clone()).collect(), | ||
| slash_reward_fraction: Perbill::from_percent(10), | ||
| history_depth: 336, |
Collaborator
There was a problem hiding this comment.
Where did 84 come from? Was it just some default value?
bwhm
approved these changes
Sep 10, 2020
mnaamani
reviewed
Sep 11, 2020
| pub const BondingDuration: pallet_staking::EraIndex = 24; | ||
| pub const SlashDeferDuration: pallet_staking::EraIndex = 6; // 1/4 the bonding duration. | ||
| pub const BondingDuration: pallet_staking::EraIndex = BONDING_DURATION; | ||
| pub const SlashDeferDuration: pallet_staking::EraIndex = BONDING_DURATION - 1; // 'slightly less' than the bonding duration. |
Member
There was a problem hiding this comment.
If we ever (mistakenly) set BONDING_DURATION to 0 we might get problems (compiler would catch attempting to set a negative number).
, or even setting it to 1 then SlashDeferDuration = 0.
So maybe setting pub const Slash_Defer_Duration = 23 then BondingDuration = Slash_Defer_Duration + 1
Contributor
Author
There was a problem hiding this comment.
The compiler prevents it with the arithmetic operation will overflow message.
Member
|
So I only had a small comment, but otherwise the numbers look good. |
mnaamani
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: