Skip to content

Comments

Proposal error message hotfix#1236

Merged
mnaamani merged 2 commits intoJoystream:iznikfrom
Lezek123:proposal-error-hotfix
Sep 5, 2020
Merged

Proposal error message hotfix#1236
mnaamani merged 2 commits intoJoystream:iznikfrom
Lezek123:proposal-error-hotfix

Conversation

@Lezek123
Copy link
Contributor

@Lezek123 Lezek123 commented Sep 4, 2020

Probable cause: Vec<u8>.toString() now seems to return the json representation of the array instead of hex string.

@Lezek123
Copy link
Contributor Author

Lezek123 commented Sep 4, 2020

I used Bytes to avoid issues like https://github.com/Joystream/apps/issues/419, but since this data can be trusted, Text will be a better choice.

It's possible that the issue with Text decoding is already solved in the new api and bytesToString workaround can be removed completely (will have to test).

@Lezek123 Lezek123 requested a review from mnaamani September 4, 2020 17:13
@mnaamani mnaamani merged commit d6f6eb5 into Joystream:iznik Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants