Genesis initial balances#1231
Merged
shamil-gadelshin merged 6 commits intoJoystream:iznikfrom Sep 4, 2020
Merged
Conversation
bwhm
approved these changes
Sep 4, 2020
shamil-gadelshin
suggested changes
Sep 4, 2020
Contributor
shamil-gadelshin
left a comment
shamil-gadelshin
left a comment
There was a problem hiding this comment.
Just a couple of minor comments.
| initial_account_balances, | ||
| ) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Please add a small comment on why we disable the lint here.
| @@ -191,6 +212,7 @@ impl ChainSpecBuilder { | |||
| } | |||
| } | |||
|
|
|||
Contributor
There was a problem hiding this comment.
I noticed you disabled this lint at least twice. Do you mind to convert it to module-scope lint with a comment?
| @@ -241,6 +264,12 @@ fn genesis_constructor( | |||
| ) | |||
| }; | |||
|
|
|||
Contributor
There was a problem hiding this comment.
What do you think about functional style or you prefer the imperative style more?
let initial_account_balances = initial_balances_path.map(|path| {initial_balances::from_json(path.as_path())}).unwrap_or_else(vec![]);
Member
Author
There was a problem hiding this comment.
Applied suggestion to other code in same function as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Option to include initial balances for accounts at genesis from exported json file.
Corresponding export script: Joystream/runtime-state-export-tools@0b787aa