Chainspec import members forum versioned store #1190

mnaamani · 2020-08-26T14:33:34Z

Update chain-spec-builder to import initial members, forum and versioned store at genesis.
Uses exported state produced by scripts in Joystream/joystream-api-examples#12

The path to the exported state as .json files can be passed as arguments to the chainspec builder:

To test (after cargo build --release)

./target/release/chain-spec-builder new \
   --authority-seeds Alice \
   --sudo-account 5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY \
   --endowed-accounts 5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY \
   --initial-members-path members.json \
   --initial-forum-path forum.json \
   --initial-content-path content.json

This will produce a chain-spec.json file. To run a chain with this configuration:

./target/release/joystream-node --chain chain-spec.json --alice --validator

shamil-gadelshin · 2020-09-01T12:03:31Z

node/Cargo.toml

 wasm-bindgen = { version = "0.2.57", optional = true }
 wasm-bindgen-futures = { version = "0.4.7", optional = true }
 browser-utils = { package = 'substrate-browser-utils', git = 'https://github.com/paritytech/substrate.git', rev = '00768a1f21a579c478fe5d4f51e1fa71f7db9fd4', optional = true}



Do you mind moving these dependencies to the 'third-party' category?

done in 6e3ebf6

shamil-gadelshin · 2020-09-01T12:04:42Z

node/src/chain_spec/content_config.rs

+            hex::decode(&self.class[2..].as_bytes()).expect("failed to parse class hex string");
+        let encoded_permissions = hex::decode(&self.permissions[2..].as_bytes())
+            .expect("failed to parse class permissions hex string");
+        ClassAndPermissions {


Do we need to panic during the initialization? Should we fail on the first error?

Yes I prefer to panic rather than introduce inconsistent state at genesis. Remember this code will only be running at the genesis construction time before any network is launched. So it would NOT affect the runtime if that is your concern?

Should we fail on the first error?

As there are references from some classes to other classes, yes there is no point continuing to import other classes since they will depend on earlier classes in some cases. So its an all or nothing scenario we want at import time.

shamil-gadelshin · 2020-09-01T12:07:47Z

runtime-modules/membership/src/genesis.rs

        self
    }
-    pub fn members(mut self, members: Vec<T::AccountId>) -> Self {
+    pub fn members(mut self, members: Vec<(T::MemberId, T::AccountId)>) -> Self {


The public method needs a comment.

updated in 14abbc4

shamil-gadelshin · 2020-09-01T12:09:01Z

runtime-modules/membership/src/lib.rs

+                    Some(member.handle.clone().into_bytes()),
+                    Some(member.avatar_uri.clone().into_bytes()),
+                    Some(member.about.clone().into_bytes())
+                ).expect("Importing Member Failed");


We should avoid panicking in the runtime code. Last time we changed panicking to the printing error message.

This code in the build(|config: &GenesisConfig<T>| { }) block isn't runtime code. It is only native code that runs when building the genesis chain-spec. So it is safe to panic.

shamil-gadelshin · 2020-09-01T12:12:01Z

runtime-modules/versioned-store-permissions/Cargo.toml

 edition = '2018'

 [dependencies]
+serde = { version = "1.0.101", features = ["derive"] }


Add this line 'serde', to the std feature.

done in a498fef

shamil-gadelshin · 2020-09-01T12:16:55Z

runtime-modules/membership/src/lib.rs

            let user_info = Self::check_user_registration_info(handle, avatar_uri, about)?;

            // ensure handle is not already registered
            Self::ensure_unique_handle(&user_info.handle)?;


Do we need this check after copying inside the insert_member?

quite right, I forgot to remove it after adding the check in insert_member

will also move the slashing to come after insert_member

done in 2957b71

shamil-gadelshin · 2020-09-01T12:17:25Z

runtime-modules/membership/src/lib.rs

            let user_info = Self::check_user_registration_info(handle, avatar_uri, about)?;

            // ensure handle is not already registered
            Self::ensure_unique_handle(&user_info.handle)?;


Do we need this check after copying inside the insert_member?

quite right, I forgot to remove it after adding the check in insert_member

done in 2957b71

shamil-gadelshin · 2020-09-01T12:18:18Z

node/src/chain_spec/initial_members.rs

@@ -0,0 +1,11 @@
+use node_runtime::{membership, AccountId, Moment};
+use std::{fs, path::Path};
+


Please add the comments for the public methods.

done in 3a01b78

shamil-gadelshin · 2020-09-01T12:18:35Z

node/src/chain_spec/forum_config.rs

@@ -0,0 +1,145 @@
+use codec::Decode;


Please add the comments for the public methods.

done in 3a01b78

shamil-gadelshin · 2020-09-01T12:18:53Z

node/src/chain_spec/content_config.rs

@@ -0,0 +1,375 @@
+use codec::Decode;


Please add the comments for the public methods.

done in 3a01b78

shamil-gadelshin

LGTM

mnaamani added 16 commits August 26, 2020 10:24

import genesis members

9628c88

import members: handle Moment

d67bcb3

import members: validate at genesis

dd0f310

node chainspec update forum import code

b33b3da

Merge branch 'iznik' into chainspec-import-members-forum-versioned-store

7b28e26

import members: cleanup

0ef00e2

fix import of forum

dafee37

refactoring

ca98879

chainspec-builder: optional arg to specify initial members

897bea9

chainspec-builder: take initial-forum-path arg

3abd0e0

node: refactor chain_spec

ea47357

import versioned-store

2e3a7d3

generate versioned_store_permissions config

44533c2

data directory: configured at genesis

1a2f87b

refactor forum_config

20ae0f4

fix some clippy warnings

a70697d

mnaamani mentioned this pull request Aug 31, 2020

Nicaea export state Joystream/joystream-api-examples#12

Closed

mnaamani requested a review from shamil-gadelshin August 31, 2020 06:27

mnaamani marked this pull request as ready for review August 31, 2020 06:31

mnaamani added 3 commits August 31, 2020 12:37

chainspec: prepare to import channels

40321c9

finish importing channels

25dcf14

fix channel id deserialization

e979fb6

shamil-gadelshin suggested changes Sep 1, 2020

View reviewed changes

mnaamani added 7 commits September 2, 2020 17:54

node chainspec: allow non contiguous entity ids in entities map

b62f2cb

node: re-org Cargo.toml

6e3ebf6

runtime-modules: Cargo.toml tweak

a498fef

additional Cargo.toml tweaks

9d3d637

runtime: members module remove redundant ensure_unique_handle calls

2957b71

node: doc public methods

3a01b78

membership module: update docs for methods on GenesisConfigBuilder

14abbc4

mnaamani requested a review from shamil-gadelshin September 3, 2020 13:17

shamil-gadelshin approved these changes Sep 3, 2020

View reviewed changes

shamil-gadelshin merged commit 65cf1e1 into Joystream:iznik Sep 3, 2020

mnaamani deleted the chainspec-import-members-forum-versioned-store branch September 4, 2020 12:42

This was referenced Sep 4, 2020

State Transfer: Members #1113

Closed

State Transfer: Forum #1114

Closed

State Transfer: Content Dir + Storage #1115

Closed

State Transfer: Content Video Channels #1197

Closed

		@@ -0,0 +1,11 @@
		use node_runtime::{membership, AccountId, Moment};
		use std::{fs, path::Path};

Chainspec import members forum versioned store #1190

Chainspec import members forum versioned store #1190

Uh oh!

Conversation

mnaamani commented Aug 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mnaamani Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shamil-gadelshin left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mnaamani commented Aug 26, 2020 •

edited

Loading

mnaamani Sep 3, 2020 •

edited

Loading