Skip to content

Conversation

@iorveth
Copy link
Contributor

@iorveth iorveth commented Jul 29, 2020

This PR removes obsolete SingleValuePropertyType abstraction.

Refactoring have mostly been done for the purpose of making ensure_property_type_size_is_valid check reusable among Single and Vector PropertyTypes

#1076 should be merged before to minimize merge conflict potential

@iorveth iorveth requested a review from bedeho July 29, 2020 11:34
@iorveth iorveth self-assigned this Jul 29, 2020
@iorveth iorveth changed the base branch from content_directory_second_try to content_dir_2 August 15, 2020 22:08
@iorveth iorveth changed the base branch from content_dir_2 to content_directory_second_try August 15, 2020 22:08
@bedeho bedeho changed the base branch from content_directory_second_try to content_dir_2 August 28, 2020 18:16
@bedeho bedeho changed the base branch from content_dir_2 to content_directory_second_try August 28, 2020 18:16
Copy link
Member

@bedeho bedeho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bedeho bedeho merged commit f7dd96f into Joystream:content_directory_second_try Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants