Skip to content

Hash commitment test coverage & refactoring #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bedeho merged 9 commits into from
Jul 31, 2020
Merged

Hash commitment test coverage & refactoring #1026

bedeho merged 9 commits into from
Jul 31, 2020

Conversation

@iorveth
Copy link
Contributor

@iorveth iorveth commented Jul 22, 2020 •
edited
Loading

The scope of this PR includes:

  1. Test coverage upgrade for respective logic
  2. Hash commitment related logic fixes
  3. Make TextToHash max length constraint optional parameter
  4. Refactoring:
  • Split off property value abstraction into separate input and output value abstractions and logic for conversions between them.
  • Split permissions logic into separate files
  • Move Class and Entity related logic into their respective files

@iorveth iorveth requested a review from bedeho July 22, 2020 10:42
@iorveth iorveth self-assigned this Jul 22, 2020
@iorveth iorveth added content-pallet network-integration-test End-to-end full network integration test labels Jul 22, 2020
@iorveth iorveth mentioned this pull request Jul 23, 2020
Merged
@iorveth iorveth changed the base branch from content_directory_second_try to content_dir_2 July 31, 2020 09:30
@iorveth iorveth changed the base branch from content_dir_2 to content_directory_second_try July 31, 2020 09:30
@iorveth iorveth changed the title Hash commitment test coverage Hash commitment test coverage & refactoring Jul 31, 2020
@bedeho bedeho merged commit fa0dcf7 into Joystream:content_directory_second_try Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bedeho bedeho Awaiting requested review from bedeho

Assignees

@iorveth iorveth

Labels

content-pallet network-integration-test End-to-end full network integration test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iorveth @bedeho