Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forum mutability threshold 2 #1003

Merged
merged 4 commits into from
Aug 4, 2020
Merged

Forum mutability threshold 2 #1003

merged 4 commits into from
Aug 4, 2020

Conversation

ondratra
Copy link
Contributor

@ondratra ondratra commented Jul 21, 2020 •
edited
Loading

Solves subtask of #766:

  • ensure input parameters are not used after // == MUTATION SAFE == comment

Task originated in #909 (comment) .

To minimize merge conflict potential, this PR assumes #980 will be merged first.

@ondratra ondratra mentioned this pull request Jul 24, 2020
Merged
bedeho
bedeho approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@bedeho bedeho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bedeho bedeho merged commit 5e735cb into Joystream:forum_2 Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bedeho bedeho bedeho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ondratra @bedeho