🔑 Remove password suggestion (#5222)

* Rework useHidePasswordInInput.tsx logic * Apply logic in required places
Joystream · Nov 8, 2023 · a92bf8c · a92bf8c
1 parent 32cf3e1
commit a92bf8c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/packages/atlas/src/components/_auth/LogInModal/LogInModal.tsx b/packages/atlas/src/components/_auth/LogInModal/LogInModal.tsx
@@ -25,7 +25,7 @@ export const LogInModal = () => {
   const [isLoading, setIsLoading] = useState(false)
   const { handleLogin, refetchCurrentUser } = useAuth()
   const { displaySnackbar } = useSnackbar()
-  const [hidePasswordProps] = useHidePasswordInInput()
+  const [hidePasswordProps] = useHidePasswordInInput(false)
   const { trackPageView } = useSegmentAnalytics()
 
   const setYppModalOpenName = useYppStore((state) => state.actions.setYppModalOpenName)

diff --git a/...as/src/components/_auth/SignUpModal/SignUpSteps/SignUpPasswordStep/SignUpPasswordStep.tsx b/...as/src/components/_auth/SignUpModal/SignUpSteps/SignUpPasswordStep/SignUpPasswordStep.tsx
@@ -94,7 +94,6 @@ export const SignUpPasswordStep: FC<SignUpPasswordStepProps> = ({
               placeholder="Password"
               {...register('password')}
               {...hidePasswordProps}
-              autoComplete="new-password"
               onClick={() => {
                 if (hasDoneInitialScroll.current || !dialogContentRef?.current) return
                 hasDoneInitialScroll.current = true

diff --git a/packages/atlas/src/hooks/useHidePasswordInInput.tsx b/packages/atlas/src/hooks/useHidePasswordInInput.tsx
@@ -3,18 +3,20 @@ import { useState } from 'react'
 import { SvgActionHide, SvgActionShow } from '@/assets/icons'
 import { InputProps } from '@/components/_inputs/Input'
 
-export const useHidePasswordInInput = (): [InputProps, () => void] => {
+export const useHidePasswordInInput = (isNew = true): [InputProps, () => void, boolean] => {
   const [isPasswordVisible, setIsPasswordVisible] = useState(false)
 
   return [
     {
       type: isPasswordVisible ? 'text' : 'password',
+      autoComplete: isPasswordVisible ? 'off' : isNew ? 'new-password' : 'off',
       actionButton: {
         icon: isPasswordVisible ? <SvgActionHide /> : <SvgActionShow />,
         onClick: () => setIsPasswordVisible((isPasswordVisible) => !isPasswordVisible),
         tooltipText: isPasswordVisible ? 'Hide' : 'Show',
       },
     },
     () => setIsPasswordVisible(false),
+    isPasswordVisible,
   ]
 }
diff --git a/packages/atlas/src/views/viewer/MembershipSettingsView/ExportSeedDialog.tsx b/packages/atlas/src/views/viewer/MembershipSettingsView/ExportSeedDialog.tsx
@@ -53,7 +53,7 @@ export const ExportSeedDialog: FC<ExportSeedDialogProps> = ({ onClose, show }) =
   const { displaySnackbar } = useSnackbar()
   const [isSubmitting, setIsSubmiting] = useState(false)
 
-  const [hidePasswordProps, resetHidePassword] = useHidePasswordInInput()
+  const [hidePasswordProps, resetHidePassword] = useHidePasswordInInput(false)
 
   const handleClose = useCallback(() => {
     reset({ password: '' })