Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Electron-based Standalone Application #129

Merged
merged 27 commits into from
May 11, 2020
Merged

Conversation

agrippa1994
Copy link
Contributor

This PR contains the bundling of the whole application into an electron executable.

It also contains the access to the operating system's keychains (Keychain on macOS & Credential Vault on Windows) for accessing password protected Docker Registries. However, at the moment this implementation does not contain a convenient way for editing these passwords in the keychains.

Any comments are welcome!

Copy link
Owner

@Joxit Joxit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thank you for your contribution 😄

This is awesome ! I think this should be moved to the example folder with helm and kubernetes examples.

electron/README.md Outdated Show resolved Hide resolved
electron/README.md Show resolved Hide resolved
electron/README.md Outdated Show resolved Hide resolved
@agrippa1994
Copy link
Contributor Author

Thank you for your feedback :) Shall I move this application to examples directory or do you want to do it?

@Joxit
Copy link
Owner

Joxit commented May 10, 2020

As you wish :) I can do it after the merge if you want.

You have finished ?

I will tweet about this PR, if you have Twitter, I can mention you 😄

@agrippa1994
Copy link
Contributor Author

@Joxit Yes, I am finished. At least I could not find any major bugs during testing on macOS, Windows and on Linux. The authentications methods seems to work fine on all major platforms.

Would you be so kind to move the application into the samples directory? I do not know how you want to have it - it is your choice :) Just note that you have to adjust the paths in the root's README.md, package.json file and adjust the path of thesync command in the electron's package.json file.

It would really appreciate if you could announce that. Since I have not a Twitter account, you could reference my Github account if you want, but it is not a must ;)

@Joxit
Copy link
Owner

Joxit commented May 11, 2020

Okay cool 👍 LGTM on Debian :)

@Joxit Joxit merged commit da95916 into Joxit:master May 11, 2020
@Joxit
Copy link
Owner

Joxit commented May 11, 2020

Thank you again for your contribution ! 🚀

@agrippa1994
Copy link
Contributor Author

You are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants