-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Electron-based Standalone Application #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, thank you for your contribution 😄
This is awesome ! I think this should be moved to the example folder with helm and kubernetes examples.
Registry authentication ui
Thank you for your feedback :) Shall I move this application to examples directory or do you want to do it? |
As you wish :) I can do it after the merge if you want. You have finished ? I will tweet about this PR, if you have Twitter, I can mention you 😄 |
@Joxit Yes, I am finished. At least I could not find any major bugs during testing on macOS, Windows and on Linux. The authentications methods seems to work fine on all major platforms. Would you be so kind to move the application into the samples directory? I do not know how you want to have it - it is your choice :) Just note that you have to adjust the paths in the root's README.md, package.json file and adjust the path of the It would really appreciate if you could announce that. Since I have not a Twitter account, you could reference my Github account if you want, but it is not a must ;) |
Okay cool 👍 LGTM on Debian :) |
Thank you again for your contribution ! 🚀 |
You are welcome :) |
This PR contains the bundling of the whole application into an electron executable.
It also contains the access to the operating system's keychains (Keychain on macOS & Credential Vault on Windows) for accessing password protected Docker Registries. However, at the moment this implementation does not contain a convenient way for editing these passwords in the keychains.
Any comments are welcome!