Skip to content

Conversation

@michaelfaith
Copy link
Collaborator

@michaelfaith michaelfaith commented Nov 12, 2025

PR Checklist

Overview

(This was failing in the renovate PR: https://github.com/JoshuaKGoldberg/package-json-validator/pulls)

Following rolldown/tsdown#517, fixedExtension is now on by default when the platform is node, which means that it's emitting mjs for any esm js files and .d.mts for esm ts files.

renovate bot and others added 2 commits November 11, 2025 23:14
Following rolldown/tsdown#517, `fixedExtension` is now on by default for node applications, which means that everything that it's emitting `mjs` for any esm js files and `.d.mts` for esm type declarations.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

👋 Hi @michaelfaith, thanks for the pull request! A scan flagged some concerns with it. Could you please take a look?

[pr-task-completion] This PR's body is missing [x] checks on the following tasks from the PR template.

Repositories often provide a set of tasks that pull request authors are expected to complete. Those tasks should be marked as completed with a [x] in the pull request description. Please complete those tasks and mark the checks as [x] completed.

[pr-linked-issue] This pull request is not linked as closing any issues. This repository keeps to GitHub issues for discussing potential changes. Most or all changes should be marked as approved in an issue before a pull request is sent to resolve them. To resolve this report:

  • If this is a straightforward documentation change that doesn't need an issue, you can ignore this report
  • If there is a backing issue, add a 'fixes #...' link to the pull request body
  • Otherwise, file an issue explaining what you'd like to happen

🗺️ This message was posted automatically by OctoGuide: a bot for GitHub repository best practices.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.17%. Comparing base (91a08e7) to head (f32c91a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #565   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files          34       34           
  Lines         756      756           
  Branches      240      240           
=======================================
  Hits          712      712           
  Misses         34       34           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@michaelfaith michaelfaith marked this pull request as ready for review November 12, 2025 01:43
@michaelfaith michaelfaith merged commit a42ed90 into main Nov 12, 2025
11 of 12 checks passed
@michaelfaith michaelfaith deleted the build/fix-tsdown branch November 12, 2025 18:22
@github-actions
Copy link
Contributor

🎉 This is included in version v0.59.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants