build: update package.json entries with explicit mjs / mts extensions #1386
build: update package.json entries with explicit mjs / mts extensions #1386michaelfaith merged 2 commits intomainfrom
Conversation
(This was failing in the renovate PR: #1373) Following rolldown/tsdown#517, fixedExtension is now on by default when the platform is node, which means that it's emitting mjs for any esm js files and .d.mts for esm ts files.
|
π Hi @michaelfaith, thanks for the pull request! A scan flagged some concerns with it. Could you please take a look? [pr-linked-issue] This pull request is not linked as closing any issues. This repository keeps to GitHub issues for discussing potential changes. Most or all changes should be marked as approved in an issue before a pull request is sent to resolve them. To resolve this report:
[pr-task-completion] This PR's body is missing
Repositories often provide a set of tasks that pull request authors are expected to complete. Those tasks should be marked as completed with a
|
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1386 +/- ##
=======================================
Coverage 96.84% 96.84%
=======================================
Files 27 27
Lines 538 538
Branches 159 159
=======================================
Hits 521 521
Misses 2 2
Partials 15 15 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
|
π This is included in version v0.72.0 π The release is available on: Cheers! π¦π |
PR Checklist
status: accepting prsOverview
(This was failing in the renovate PR: #1373)
Following rolldown/tsdown#517,
fixedExtensionis now on by default when the platform is node, which means that it's emittingmjsfor any esm js files and.d.mtsfor esm ts files.