Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getLanguageServiceHost() to support TS 4.8 #61

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Update getLanguageServiceHost() to support TS 4.8 #61

merged 2 commits into from
Sep 7, 2022

Conversation

danvk
Copy link
Collaborator

@danvk danvk commented Sep 7, 2022

PR Checklist

Overview

As of microsoft/TypeScript#47495 there are two new required properties on LanguageServiceHost. This fills them out.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 7, 2022
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@JoshuaKGoldberg JoshuaKGoldberg merged commit 63f28b3 into main Sep 7, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the support-ts-48 branch September 7, 2022 21:05
@github-actions GitHub Actions
Copy link

🎉 This is included in version v0.3.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript 4.8 compatibility
2 participants
@danvk @JoshuaKGoldberg