Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug: Rerun suggestions don't factor in --base #905

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 30, 2023 · 1 comment 路 Fixed by #992
Closed
3 tasks done

馃悰 Bug: Rerun suggestions don't factor in --base #905

JoshuaKGoldberg opened this issue Sep 30, 2023 · 1 comment 路 Fixed by #992
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Sep 30, 2023

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Rerun suggestions should use --base to suggest what base starting situation to work with.

For example, if started with:

npx create-typescript-app --base common --mode create -author JoshuaKGoldberg --description asdf --mode create --owner asdf --repository asdf --title asdf

...then the rerun suggestion should be something like:

Tip: to run again with the same input values, use: --base common --mode create --author JoshuaKGoldberg --description asdf --owner asdf --repository asdf --title asdf

Actual

Base template (--base) is not factored in, so exclusions are printed manually:

Tip: to run again with the same input values, use: npx create-typescript-app --mode create --base common --access public --author JoshuaKGoldberg --description asdf --email-github [email protected] --email-npm [email protected] --exclude-compliance true --exclude-lint-deprecation true --exclude-lint-eslint true --exclude-lint-jsdoc true --exclude-lint-json true --exclude-lint-md true --exclude-lint-package-json true --exclude-lint-packages true --exclude-lint-perfectionist true --exclude-lint-regex true --exclude-lint-spelling true --exclude-lint-strict true --exclude-lint-stylistic true --exclude-lint-yml true --mode create --owner asdf --repository asdf true --title asdf

Additional Info

No response

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Sep 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Sep 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg changed the title 馃悰 Bug: Rerun suggestions 馃悰 Bug: Rerun suggestions don't factor in --base Sep 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg removed this from the Post-Rename Migration milestone Sep 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg removed their assignment Oct 2, 2023
JoshuaKGoldberg added a commit that referenced this issue Nov 9, 2023
<!-- 馃憢 Hi, thanks for sending a PR to create-typescript-app! 馃挅.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #905
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

<!-- Description of what is changed and how the code change does that.
-->
Add additional filter logic to check if an options entry was excluded by
the base, and filter it out of the suggested rerun flags, add new test,
update failing test with suggestion from jest

(>^u^)><(^u^)><(^u^<)

---------

Co-authored-by: Josh Goldberg <[email protected]>
Copy link

github-actions bot commented Nov 9, 2023

馃帀 This is included in version v1.43.1 馃帀

The release is available on:

Cheers! 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant