New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: gh workflow trigger still in release.yml template #863

Closed

3 tasks done

JoshuaKGoldberg opened this issue Sep 21, 2023 · 1 comment · Fixed by #868

Closed

3 tasks done

🐛 Bug: gh workflow trigger still in release.yml template #863

JoshuaKGoldberg opened this issue Sep 21, 2023 · 1 comment · Fixed by #868

Assignees

Labels

status: accepting prs type: bug

Milestone

Post-Rename Migra...

Owner

JoshuaKGoldberg commented Sep 21, 2023

Bug Report Checklist

I have tried restarting my IDE and the issue persists.
I have pulled the latest main branch of the repository.
I have searched for related issues and found none that matched my issue.

Expected

I'd removed the manual trigger in #535. That line shouldn't show up in templated repositories.

Actual

It is.

Additional Info

No response

The text was updated successfully, but these errors were encountered:

JoshuaKGoldberg added type: bug status: accepting prs labels

JoshuaKGoldberg added this to the Post-Rename Migration milestone

JoshuaKGoldberg self-assigned this

JoshuaKGoldberg mentioned this issue

fix: remove unnecessary gh workflow run #868

Merged

3 tasks

JoshuaKGoldberg closed this as completed in #868

JoshuaKGoldberg added a commit that referenced this issue


          fix: remove unnecessary gh workflow run (#868)

cc0cbaf

## PR Checklist

- [x] Addresses an existing open issue: fixes #863
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Removing this aligns `release.yml` to the template, yay!

github-actions bot commented Oct 2, 2023

🎉 This is included in version v1.32.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment