Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Crash when repo has two labels equivalent to an outcome #767

Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 3, 2023 · 1 comment · Fixed by #768
Closed
3 tasks done

🐛 Bug: Crash when repo has two labels equivalent to an outcome #767

JoshuaKGoldberg opened this issue Sep 3, 2023 · 1 comment · Fixed by #768
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Post-Rename Migra...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

If a repo has both, say, area: documentation and documentation labels:

  • area: documentation should be edited as needed (color, description)
  • documentation should be deleted

Actual

This logic is not accounted for. Only one existing equivalent may exist per getExistingEquivalentLabel (singular).

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Sep 3, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the Post-Rename Migration milestone Sep 3, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Sep 3, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 3, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🐛 Bug: when repo has two labels equivalent to an outcome 🐛 Bug: Crash when repo has two labels equivalent to an outcome Sep 3, 2023
JoshuaKGoldberg added a commit that referenced this issue Sep 3, 2023
@JoshuaKGoldberg
fix: account for multiple existing equivalent labels (#768)
5665ed1 
## PR Checklist

- [x] Addresses an existing open issue: fixes #767
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Changes `getExistingEquivalentLabel` (singular) to
`getExistingEquivalentLabels` (plural).
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

🎉 This is included in version v1.29.28 🎉

The release is available on:

Cheers! 📦🚀

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 27, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Post-Rename Migration
Development

Successfully merging a pull request may close this issue.

fix: account for multiple existing equivalent labels JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg