Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Label setups misses existing prefixed labels #529

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jun 14, 2023 · 2 comments · Fixed by #530
Closed
3 tasks done

🐛 Bug: Label setups misses existing prefixed labels #529

JoshuaKGoldberg opened this issue Jun 14, 2023 · 2 comments · Fixed by #530
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

When a label such as area: documentation already exists in the repo, hydrateRepositoryLabels > getExistingEquivalentLabel should find that as an existing label.

Actual

Because of the fun .replace logic, existing prefixed labels are actually missed...

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Jun 14, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jun 14, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jun 14, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jun 14, 2023
@JoshuaKGoldberg
fix: match existing, prefixed labels in setup (#530)
6ed23cf 
## PR Checklist

- [x] Addresses an existing open issue: fixes #529
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Fixes the `.find` logic to match on an aliased or prefixed label.
@github-actions
Copy link

🎉 This is included in version v1.28.15 🎉

The release is available on:

Cheers! 📦🚀

1 similar comment
@github-actions
Copy link

🎉 This is included in version v1.28.15 🎉

The release is available on:

Cheers! 📦🚀

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 27, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: match existing, prefixed labels in setup JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg