-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixes reading tsconfig and handling compilerOptions #1542
Draft
rubiesonthesky
wants to merge
10
commits into
JoshuaKGoldberg:main
Choose a base branch
from
rubiesonthesky:fix-reading-tsconfig-and-collecting-filenames
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix: fixes reading tsconfig and handling compilerOptions #1542
rubiesonthesky
wants to merge
10
commits into
JoshuaKGoldberg:main
from
rubiesonthesky:fix-reading-tsconfig-and-collecting-filenames
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubiesonthesky
changed the title
Fix reading tsconfig and collecting filenames
fix: fixes reading tsconfig and handling compilerOptions
Apr 7, 2024
This was referenced Apr 7, 2024
3 tasks
rubiesonthesky
added
the
status: blocked
Waiting for something else to be resolved 🙅
label
May 5, 2024
rubiesonthesky
removed
the
status: blocked
Waiting for something else to be resolved 🙅
label
Nov 29, 2024
I guess I should update this PR now :D |
😅 yeah that'd be great. But if you don't have the time and don't want to deal with merge conflicts from me skipping out for a half a year, no worries - lmk and I can step in! ❤️ |
JoshuaKGoldberg
added
the
status: waiting for author
Needs an action taken by the original poster
label
Dec 1, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prs
Overview
Follows #1534
tsconfig
and handling the values.compilerOptions
have been changed.typestat.json
should not disablenoImplicitAny
ornoImplicitThis
if they are enabled intsconfig
.ts.parseJsonConfigFileContent
is setup. This can been seen in action for example in include test. While before we hadinclude: []
, now we have list of files.ts-expect-error
comments, do not add full path to files. If there are multiple people working in the same project, absolute path will not be same for everyone.createProgramConfiguration
andparseRawCompilerOptions
both useparseJsonConfigFileContents
function. No need to duplicate this code.