Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes reading tsconfig and handling compilerOptions #1542

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

rubiesonthesky
Copy link
Collaborator

PR Checklist

Overview

Follows #1534

  • Fixes reading tsconfig and handling the values.
    • This can be seen in the snapshot files, where values for compilerOptions have been changed.
  • Options from typestat.json should not disable noImplicitAny or noImplicitThis if they are enabled in tsconfig.
  • Fix reading included files by changing how ts.parseJsonConfigFileContent is setup. This can been seen in action for example in include test. While before we had include: [], now we have list of files.
  • When adding ts-expect-error comments, do not add full path to files. If there are multiple people working in the same project, absolute path will not be same for everyone.
  • createProgramConfiguration and parseRawCompilerOptions both use parseJsonConfigFileContents function. No need to duplicate this code.

@rubiesonthesky rubiesonthesky changed the title Fix reading tsconfig and collecting filenames fix: fixes reading tsconfig and handling compilerOptions Apr 7, 2024
@rubiesonthesky rubiesonthesky marked this pull request as ready for review April 7, 2024 17:31
@rubiesonthesky rubiesonthesky added the status: blocked Waiting for something else to be resolved 🙅 label May 5, 2024
@rubiesonthesky rubiesonthesky removed the status: blocked Waiting for something else to be resolved 🙅 label Nov 29, 2024
@rubiesonthesky
Copy link
Collaborator Author

I guess I should update this PR now :D

@JoshuaKGoldberg
Copy link
Owner

😅 yeah that'd be great. But if you don't have the time and don't want to deal with merge conflicts from me skipping out for a half a year, no worries - lmk and I can step in! ❤️

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Dec 1, 2024
@rubiesonthesky rubiesonthesky marked this pull request as draft December 6, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author Needs an action taken by the original poster
Projects
None yet
2 participants